Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Add small bug fixes + log message improvements #366

Merged
merged 5 commits into from
Nov 11, 2024
Merged

[FIX] Add small bug fixes + log message improvements #366

merged 5 commits into from
Nov 11, 2024

Conversation

DESm1th
Copy link
Contributor

@DESm1th DESm1th commented Nov 11, 2024

This pull request

  • Adds small reminders of how to fix errors to some log messages (a5fd143, 98f9cd5, 0e712fc)
  • Ensures the correct list of tags are used when sessions are shared (af0161f)
  • Ensures immediate exception happens when xnat login has failed due to expired password (instead of later on when the connection actually gets used) (31bc142)

@DESm1th DESm1th requested a review from a team as a code owner November 11, 2024 23:10
@DESm1th DESm1th merged commit 40a6a58 into TIGRLab:main Nov 11, 2024
3 of 5 checks passed
@pep8speaks
Copy link

Hello @DESm1th, thank you for submitting the Pull Request!

Line 92:80: E501 line too long (80 > 79 characters)

To test for issues locally, pip install flake8 and then run flake8 datman.

@DESm1th DESm1th deleted the fixes branch November 11, 2024 23:10
@github-actions github-actions bot added the fix Tagged PR fixes a bug label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimjetwav kimjetwav Awaiting requested review from kimjetwav kimjetwav is a code owner automatically assigned from TIGRLab/datman-reviewers

@yaraldabagh yaraldabagh Awaiting requested review from yaraldabagh yaraldabagh is a code owner automatically assigned from TIGRLab/datman-reviewers

Assignees
No one assigned
Labels
fix Tagged PR fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DESm1th @pep8speaks